Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @inngest/test not capturing initial errors #741

Merged
merged 7 commits into from
Nov 12, 2024

Conversation

jpwilliams
Copy link
Member

@jpwilliams jpwilliams commented Nov 12, 2024

Summary

Fixes @inngest/test not capturing initial errors within a function as well as steps sometimes running twice.

For now this continues to not model retries, as per the README.

Checklist

  • Added a docs PR that references this PR N/A Bug fix
  • Added unit/integration tests N/A Using in @inngest/middleware-validation
  • Added changesets if applicable

Related

@jpwilliams jpwilliams added the Bug Something isn't working label Nov 12, 2024
@jpwilliams jpwilliams self-assigned this Nov 12, 2024
Copy link

changeset-bot bot commented Nov 12, 2024

🦋 Changeset detected

Latest commit: 0888c05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@inngest/test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jpwilliams jpwilliams added the prerelease/test Create snapshot releases for a PR for the "@inngest/test" package. label Nov 12, 2024
@inngest-release-bot
Copy link
Collaborator

A user has added the prerelease/test label, so this PR will be published to npm with the tag pr-741. It will be updated with the latest changes as you push commits to this PR.

You can install this prerelease version with:

npm install @inngest/test@pr-741

The last release was built and published from 0888c05.

@jpwilliams jpwilliams merged commit 6782497 into main Nov 12, 2024
55 checks passed
@jpwilliams jpwilliams deleted the jack/fix-test-first-error branch November 12, 2024 12:43
jpwilliams pushed a commit that referenced this pull request Nov 12, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @inngest/test@0.1.1

### Patch Changes

- [#741](#741)
[`6782497`](6782497)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix the first
step in a run running twice

- [#741](#741)
[`6782497`](6782497)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix immediate
function/step failures not returning `error` correctly

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working 📦 @inngest/test prerelease/test Create snapshot releases for a PR for the "@inngest/test" package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] @inngest/test errors on steps do not throw [BUG] @inngest/test triggers step twice
4 participants